-
-
pidgin/pidginaccountsenabledmenu.c (Diff revision 1) instead of hardcoding a number here, we should put a section with an id in the
enabled-accountmenu ingtk/menus.ui -
-
pidgin/pidginaccountsenabledmenu.c (Diff revision 1) this should probably be signed on as then we have a connection.
Add protocol actions to Pidgin account menu
Review Request #1364 — Created March 22, 2022 and submitted
| Information | |
|---|---|
| QuLogic | |
| pidgin/pidgin | |
| default | |
| PIDGIN-17497 | |
|
|
|
| 1365 | |
| Reviewers | |
| pidgin | |
Add protocol actions to Pidgin account menu
Compiled with other reviews and ran. Also added multiple demo accounts and disabled them one by one and verified they continued to work.
| Summary | Author |
|---|---|
| Gary Kramlich |
| Description | From | Last Updated |
|---|---|---|
|
This will be replaced by another rr once /r/1360 is landed. |
 grim
|
|
|
instead of hardcoding a number here, we should put a section with an id in the enabled-account menu in gtk/menus.ui |
grim
|
|
|
might want to use g_list_foreach |
grim
|
|
|
I'm also realizing now that this should be a method in PidginApplication as we'll need to insert the action group … |
grim
|
|
|
this should probably be signed on as then we have a connection. |
grim
|
-
-
pidgin/pidginaccountsenabledmenu.c (Diff revision 1) I'm also realizing now that this should be a method in
PidginApplicationas we'll need to insert the action group into new windows too...
Change Summary:
update depends on
Depends On: |
|
|---|
Change Summary:
Update with all the stuff we've learned/created since this was originally opened.
Testing Done: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
|||||||||
Diff: |
Revision 2 (+142) |
