Add protocol actions to Pidgin account menu

Review Request #1364 — Created March 22, 2022 and updated

QuLogic
pidgin/pidgin
default
PIDGIN-17497
1511, 1360, 1356
1365
pidgin
Add protocol actions to Pidgin account menu

Compiled with other reviews and ran.

Summary
Add protocol actions to Pidgin account menu
Description From Last Updated

This will be replaced by another rr once /r/1360 is landed.

grimgrim

instead of hardcoding a number here, we should put a section with an id in the enabled-account menu in gtk/menus.ui

grimgrim

might want to use g_list_foreach

grimgrim

I'm also realizing now that this should be a method in PidginApplication as we'll need to insert the action group ...

grimgrim

this should probably be signed on as then we have a connection.

grimgrim
grim
  1. 
      
  2. pidgin/pidginaccountsenabledmenu.c (Diff revision 1)
     
     

    instead of hardcoding a number here, we should put a section with an id in the enabled-account menu in gtk/menus.ui

  3. pidgin/pidginaccountsenabledmenu.c (Diff revision 1)
     
     

    might want to use g_list_foreach

  4. pidgin/pidginaccountsenabledmenu.c (Diff revision 1)
     
     

    this should probably be signed on as then we have a connection.

  5. 
      
grim
grim
  1. 
      
  2. pidgin/pidginaccountsenabledmenu.c (Diff revision 1)
     
     

    I'm also realizing now that this should be a method in PidginApplication as we'll need to insert the action group into new windows too...

  3. 
      
grim
Review request changed
grim
  1. 
      
  2. This will be replaced by another rr once /r/1360 is landed.

    1. I meant /r/1511 which replaced /r/1360, sorry...

  3. 
      
Loading...