Fix the infinite resizing freeze

 






 

 


  Review Request #1342
  —
  Created March 13, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  belgin
 









 
 

  pidgin/pidgin
 









 
 

  release-2.x.y
 









 
 

  PIDGIN-16753, PIDGIN-16999, PIDGIN-17287, PIDGIN-17413, PIDGIN-17430, PIDGIN-17568, PIDGIN-17602
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
This appears related to libpango somehow, as in Debian

Bullseye, libpango splits URLs with dashes at the end,

but in Debian Bookworm, the URLs are not split with dashes

at the end, and the bug does not appear to be triggered 

in Bookworm.


This patch makes the assumption that the gtkimhtml widgets

stored in a PidginConversation normally resize in an

alternating manner. However, when the bug is triggered,

only the "entry" gtkimhtml member of PidginConversation

resizes, so we allow "entry" to resize only up to 3 times

in a row.

 








  


 
 

  
Compiled and tested on several desktop environments on a few 

GNU/Linux distros by pasting the link mentioned 

here https://issues.imfreedom.org/issue/PIDGIN-17413 moving 

the cursor at the beginning of the buffer, and holding 

the spacebar pressed.

 







 









 





  








 




 







   

    
    
Diff Revision 3


This is not the most recent revision of the diff. The latest diff is revision 10. See what's changed.

    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix the infinite resizing freeze
     
This appears related to libpango somehow, as in Debian
Bullseye, libpango splits URLs with dashes at the end,
but in Debian Bookworm, the URLs are not split with dashes
at the end, and the bug does not appear to be triggered
in Bookworm.

This patch makes the assumption that the gtkimhtml widgets
stored in a PidginConversation normally resize in an
alternating manner. However, when the bug is triggered,
only the "entry" gtkimhtml member of PidginConversation
resizes, so we allow "entry" to resize only up to 3 times
in a row.

Testing Done:
Compiled and tested on several desktop environments on a few
GNU/Linux distros by pasting the link mentioned
here https://issues.imfreedom.org/issue/PIDGIN-17413 moving
the cursor at the beginning of the buffer, and holding
the spacebar pressed.

Reviewed at https://reviews.imfreedom.org/r/1342/

    

   
  		
  94c072f2ebc963a2bfb430458b324b50c8a2fd5c
  Belgin Știrbu
 


 
  
   
  
  
   
  
 
 
  
   
    

     Fix the infinite resizing freeze
     
This appears related to libpango somehow, as in Debian
Bullseye, libpango splits URLs with dashes at the end,
but in Debian Bookworm, the URLs are not split with dashes
at the end, and the bug does not appear to be triggered
in Bookworm.

This patch makes the assumption that the gtkimhtml widgets
stored in a PidginConversation normally resize in an
alternating manner. However, when the bug is triggered,
only the "entry" gtkimhtml member of PidginConversation
resizes, so we allow "entry" to resize only up to 3 times
in a row.

Testing Done:
Compiled and tested on several desktop environments on a few
GNU/Linux distros by pasting the link mentioned
here https://issues.imfreedom.org/issue/PIDGIN-17413 moving
the cursor at the beginning of the buffer, and holding
the spacebar pressed.

Reviewed at https://reviews.imfreedom.org/r/1342/

    

   
  		
  0306d1656bec79650b13b48ab85e4a7e2a91b884
  Belgin Știrbu
 


 
  
   
  
  
   
  
 
 
  
   
    

     Fix freeze when resizing window with a link pasted in the entry
     
box.

    

   
  		
  1ebf180f092803a44ebf29956ddaaad7890c7d69
  Belgin Știrbu
 




    


    
    

   

  

 









 

  

   
    

     
      
      pidgin/gtkconv.c
     
    

   
  

 



 

  

   
    

     
      
      pidgin/gtkimhtml.c
     
    

   
  

 










     

    

   

  

  

   
   Loading...