Summary

Create a menu controller that will keep a GMenu in sync with the disabled accounts in libpurple

Review Request #1326 — Created March 11, 2022 and submitted March 14, 2022, 6:19 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Create a menu controller that will keep a GMenu in sync with the disabled accounts in libpurple

Testing Done

Used the account manager to disable and account, then disabled it from the menu and verified that the item was removed.

Commits

Summary	ID
Create a menu controller that will keep a GMenu in sync with the disabled accounts in libpurple	152a8a9425c5602460f3cc7d81524d81cfeed3de

Issues

Description	From	Last Updated
its	QuLogic	March 14, 2022, 5:13 a.m.
Do we need this type?	QuLogic	March 14, 2022, 5:13 a.m.
Should this be translateable? (probably would need a translator comment too, then.)	QuLogic	March 14, 2022, 5:13 a.m.
its	QuLogic	March 14, 2022, 5:11 a.m.

libpurple/purpleaccountmanager.h (Diff revision 1)
Show all issues
```
its
```

pidgin/pidginaccountsdisabledmenu.c (Diff revision 1)

Show all issues

Do we need this type?

grim March 14, 2022, 3:25 a.m.

I thought we did, but now you have me seconding guessing myself...

pidgin/pidginaccountsdisabledmenu.c (Diff revision 1)

Show all issues

Should this be translateable? (probably would need a translator comment too, then.)

grim March 14, 2022, 3:37 a.m.

Do we need a comment? I'd hope the arguments are self explanatory enough?

QuLogic March 14, 2022, 3:40 a.m.

Translators do not see the line they are translating, only the string and the translator comment.

grim March 14, 2022, 3:41 a.m.

Right right, it provides a line number, but not the contents, just the string that's marked, got it! Man it's been way too long for me when it comes to translations...

pidgin/pidginapplication.c (Diff revision 1)
Show all issues
```
its
```

Change Summary:

fix issues and use a weak ref to avoid needing our own data structure.

Commits:

	Summary	ID
	Create a menu controller that will keep a GMenu in sync with the disabled accounts in libpurple	eea9e47579378c4f8306a7574b55453bf4e628ed
	Create a menu controller that will keep a GMenu in sync with the disabled accounts in libpurple	152a8a9425c5602460f3cc7d81524d81cfeed3de

Diff:

Revision 2 (+508 -6)

Show changes

	libpurple/purpleaccountmanager.h
	libpurple/purpleaccountmanager.c
	pidgin/meson.build
	pidgin/pidginaccountsdisabledmenu.h
	pidgin/pidginaccountsdisabledmenu.c
	pidgin/pidginapplication.c
	pidgin/resources/gtk/menus.ui
	po/POTFILES.in

Ship it!

```
Ship It!
```

Review Board 6.0.2