Change Summary:
added a screenshot
Added Files: |
---|
Review Request #1318 — Created March 8, 2022 and submitted
The old code was left to keep this change as clean as possible and will be
removed afterwards.Drag and drop as been removed as it's completely different in GTK4 and I didn't
want to waste time on it since it's going to be deleted when it's rewritten.I also didn't implement the double click to modify account as that's different
in GTK4 and we don't yet have new Event Controller for it in GTK3.Support for selecting multiple accounts was dropped and now only one account may be selected at a time.
Finally, I changed the title of the "Delete" button to "Remove" as "Remove"
seems more clear.
Used the previous dialog to add, remove, and modify accounts and verified they were updated appropriately.
Also started pidgin without any accounts enabled, to verify that the new dialog was shown instead of the old.
Tested the add, modify, remove, and close buttons.
Tested that the modify and remove buttons are only sensitive when an account is selected.
Summary | ID |
---|---|
16e27cf70eb40cbf30ca9c958f73180ec354aaf9 |
Description | From | Last Updated |
---|---|---|
Missing full stop. |
lifesfaded | |
I guess we move this to the action like the other dialog? |
QuLogic | |
Unused. |
QuLogic | |
Unused. |
QuLogic | |
Unused. |
QuLogic |
use row_activated signal on the treeview to open the editor and add license information to the ui file.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1314 -4) |
add the missing global header guard
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1322 -4) |
Add the missing doc comments.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+1356 -4) |
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+1356 -4) |
pidgin/pidginaccountmanager.c (Diff revision 5) |
---|
I guess we move this to the action like the other dialog?
address review findings and use gtk_window_present_with_time instead of gtk_widget_show_all
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 6 (+1346 -4) |