Create a new PidginAccountManager that replaces the manually built one.

Review Request #1318 — Created March 8, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

The old code was left to keep this change as clean as possible and will be
removed afterwards.

Drag and drop as been removed as it's completely different in GTK4 and I didn't
want to waste time on it since it's going to be deleted when it's rewritten.

I also didn't implement the double click to modify account as that's different
in GTK4 and we don't yet have new Event Controller for it in GTK3.

Support for selecting multiple accounts was dropped and now only one account may be selected at a time.

Finally, I changed the title of the "Delete" button to "Remove" as "Remove"
seems more clear.

Used the previous dialog to add, remove, and modify accounts and verified they were updated appropriately.
Also started pidgin without any accounts enabled, to verify that the new dialog was shown instead of the old.
Tested the add, modify, remove, and close buttons.
Tested that the modify and remove buttons are only sensitive when an account is selected.

Summary ID
Create a new PidginAccountManager that replaces the manually built one.
The old code was left to keep this change as clean as possible and will be removed afterwards. Drag and drop as been removed as it's completely different in GTK4 and I didn't want to waste time on it since it's going to be deleted when it's rewritten. I also didn't implement the double click to modify account as that's different in GTK4 and we don't yet have new Event Controller for it in GTK3. Finally, I changed the title of the "Delete" button to "Remove" as "Remove" seems more clear.
16e27cf70eb40cbf30ca9c958f73180ec354aaf9

Description From Last Updated

Missing full stop.

lifesfadedlifesfaded

I guess we move this to the action like the other dialog?

QuLogicQuLogic

Unused.

QuLogicQuLogic

Unused.

QuLogicQuLogic

Unused.

QuLogicQuLogic
grim
grim
grim
grim
grim
lifesfaded
  1. 
      
  2. pidgin/pidginaccountmanager.c (Diff revision 4)
     
     

    Missing full stop.

  3. 
      
grim
QuLogic
  1. 
      
  2. pidgin/pidginaccountmanager.c (Diff revision 5)
     
     

    I guess we move this to the action like the other dialog?

  3. pidgin/pidginaccountmanager.c (Diff revision 5)
     
     

    Unused.

  4. pidgin/pidginaccountmanager.c (Diff revision 5)
     
     

    Unused.

  5. pidgin/pidginaccountmanager.c (Diff revision 5)
     
     

    Unused.

  6. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...