Overhaul the status box

Review Request #1312 — Created March 4, 2022 and submitted

Information

pidgin/pidgin
default

Reviewers

  • Subclass GtkBox instead of GtkContainer
  • Remove message editing
  • Use a GtkComboBox instead of our fake GtkComboBox
  • Move to item id's rather than indexes
  • Moved new status, and saved status to GActions
  • Removed the account and token_account properties. we now show primitives and
    saved status
  • Removed the ability to delete saved status from the widget
  • Use a widget template to construct the ui elements
  • Removed the connection detection stuff

Verified status were updated when used in the saved status manager.
Verified that the new status and saved status actions work.
Verified that the primitive status work.
Verified that the saved statuses work.

Summary ID
Overhaul the status box
* Subclass GtkBox instead of GtkContainer * Remove message editing * Use a GtkComboBox instead of our fake GtkComboBox * Move to item id's rather than indexes * Moved new status, and saved status to GActions * Removed the account and token_account properties. we now show primitives and saved status * Removed the ability to delete saved status from the widget * Use a widget template to construct the ui elements
f6bd096a84170fd799892ee918455c0769150c79
Description From Last Updated

This currently has a weirdo infinite loop when you have zero saved or transient status. I haven't figured out yet...

grimgrim

Missing license.

lifesfadedlifesfaded

Mark all unused.

QuLogicQuLogic

Don't need the semicolon.

QuLogicQuLogic

Can rename to parent now.

QuLogicQuLogic

Remove?

QuLogicQuLogic

If you're in an infinite loop, you segfault by running out of stack space, no?

QuLogicQuLogic
grim
  1. 
      
  2. Show all issues

    This currently has a weirdo infinite loop when you have zero saved or transient status. I haven't figured out yet...

  3. 
      
grim
grim
lifesfaded
  1. 
      
  2. pidgin/resources/Status/box.ui (Diff revision 2)
     
     
    Show all issues

    Missing license.

  3. 
      
grim
QuLogic
  1. 
      
  2. pidgin/pidginapplication.c (Diff revision 3)
     
     
     
    Show all issues

    Mark all unused.

  3. pidgin/pidginstatusbox.h (Diff revision 3)
     
     
    Show all issues

    Don't need the semicolon.

  4. pidgin/pidginstatusbox.c (Diff revision 3)
     
     
    Show all issues

    Can rename to parent now.

  5. pidgin/pidginstatusbox.c (Diff revision 3)
     
     
    Show all issues

    Remove?

  6. pidgin/pidginstatusbox.c (Diff revision 3)
     
     
    Show all issues

    If you're in an infinite loop, you segfault by running out of stack space, no?

  7. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed
Status:
Completed