Summary

Overhaul the status box

Review Request #1312 — Created March 4, 2022 and submitted April 5, 2022, 4:16 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17591

Depends On

Reviewers

Groups

pidgin

People

Description


Subclass GtkBox instead of GtkContainer
Remove message editing
Use a GtkComboBox instead of our fake GtkComboBox
Move to item id's rather than indexes
Moved new status, and saved status to GActions
Removed the account and token_account properties.  we now show primitives and

  saved status
Removed the ability to delete saved status from the widget
Use a widget template to construct the ui elements
Removed the connection detection stuff

Testing Done

Verified status were updated when used in the saved status manager.
Verified that the new status and saved status actions work.
Verified that the primitive status work.
Verified that the saved statuses work.

Commits

Summary	ID
Overhaul the status box * Subclass GtkBox instead of GtkContainer * Remove message editing * Use a GtkComboBox instead of our fake GtkComboBox * Move to item id's rather than indexes * Moved new status, and saved status to GActions * Removed the account and token_account properties. we now show primitives and saved status * Removed the ability to delete saved status from the widget * Use a widget template to construct the ui elements	f6bd096a84170fd799892ee918455c0769150c79

Summary

Overhaul the status box

* Subclass GtkBox instead of GtkContainer * Remove message editing * Use a GtkComboBox instead of our fake GtkComboBox * Move to item id's rather than indexes * Moved new status, and saved status to GActions * Removed the account and token_account properties. we now show primitives and saved status * Removed the ability to delete saved status from the widget * Use a widget template to construct the ui elements

f6bd096a84170fd799892ee918455c0769150c79

Issues

Description	From	Last Updated
This currently has a weirdo infinite loop when you have zero saved or transient status. I haven't figured out yet...	grim	March 29, 2022, 2:09 a.m.
Missing license.	lifesfaded	March 29, 2022, 2:09 a.m.
Mark all unused.	QuLogic	April 5, 2022, 4:13 a.m.
Don't need the semicolon.	QuLogic	April 5, 2022, 4:13 a.m.
Can rename to parent now.	QuLogic	April 5, 2022, 4:13 a.m.
Remove?	QuLogic	April 5, 2022, 4:13 a.m.
If you're in an infinite loop, you segfault by running out of stack space, no?	QuLogic	April 5, 2022, 4:14 a.m.

Show all issues

This currently has a weirdo infinite loop when you have zero saved or transient status. I haven't figured out yet...

Change Summary:

changed to delete gtkstatusbox and add pidginstatusbox instead. infinite loop still present.

Commits:

	Summary	ID
	Overhaul the status box * Subclass GtkBox instead of GtkContainer * Remove message editing * Use a GtkComboBox instead of our fake GtkComboBox * Move to item id's rather than indexes * Moved new status, and saved status to GActions * Removed the account and token_account properties. we now show primitives and saved status * Removed the ability to delete saved status from the widget * Use a widget template to construct the ui elements	ceddd18adae32b7474722eef67c03eaa80364ff0
	Overhaul the status box * Subclass GtkBox instead of GtkContainer * Remove message editing * Use a GtkComboBox instead of our fake GtkComboBox * Move to item id's rather than indexes * Moved new status, and saved status to GActions * Removed the account and token_account properties. we now show primitives and saved status * Removed the ability to delete saved status from the widget * Use a widget template to construct the ui elements	39e1980e4a92d9fb0548474816a9228a2eb4ad42

Diff:

Revision 2 (+1082 -4200)

Show changes

	ChangeLog.API
	libpurple/savedstatuses.c
	pidgin/gtkaccount.c
	pidgin/gtkblist.c
	pidgin/gtkconn.c
	pidgin/gtkstatusbox.h
	pidgin/gtkstatusbox.c
	pidgin/meson.build
	6 more

Change Summary:

add a ticket

Bugs:

+	PIDGIN-17591

pidgin/resources/Status/box.ui (Diff revision 2)
Show all issues
```
Missing license.
```

Change Summary:

Fix the infinite loop.

Commits:

	Summary	ID
	Overhaul the status box * Subclass GtkBox instead of GtkContainer * Remove message editing * Use a GtkComboBox instead of our fake GtkComboBox * Move to item id's rather than indexes * Moved new status, and saved status to GActions * Removed the account and token_account properties. we now show primitives and saved status * Removed the ability to delete saved status from the widget * Use a widget template to construct the ui elements	39e1980e4a92d9fb0548474816a9228a2eb4ad42
	Overhaul the status box * Subclass GtkBox instead of GtkContainer * Remove message editing * Use a GtkComboBox instead of our fake GtkComboBox * Move to item id's rather than indexes * Moved new status, and saved status to GActions * Removed the account and token_account properties. we now show primitives and saved status * Removed the ability to delete saved status from the widget * Use a widget template to construct the ui elements	32dd582985d273a7289f9a74c48ea725eb006b07

Diff:

Revision 3 (+1160 -4204)

Show changes

	ChangeLog.API
	libpurple/savedstatuses.c
	pidgin/gtkaccount.c
	pidgin/gtkblist.c
	pidgin/gtkconn.c
	pidgin/gtkstatusbox.h
	pidgin/gtkstatusbox.c
	pidgin/meson.build
	6 more

pidgin/pidginapplication.c (Diff revision 3)
Show all issues
```
Mark all unused.
```
pidgin/pidginstatusbox.h (Diff revision 3)
Show all issues
```
Don't need the semicolon.
```
pidgin/pidginstatusbox.c (Diff revision 3)
Show all issues
```
Can rename to parent now.
```
pidgin/pidginstatusbox.c (Diff revision 3)
Show all issues
```
Remove?
```

pidgin/pidginstatusbox.c (Diff revision 3)

Show all issues

If you're in an infinite loop, you segfault by running out of stack space, no?

Change Summary:

Address all the things!

Commits:

	Summary	ID
	Overhaul the status box * Subclass GtkBox instead of GtkContainer * Remove message editing * Use a GtkComboBox instead of our fake GtkComboBox * Move to item id's rather than indexes * Moved new status, and saved status to GActions * Removed the account and token_account properties. we now show primitives and saved status * Removed the ability to delete saved status from the widget * Use a widget template to construct the ui elements	32dd582985d273a7289f9a74c48ea725eb006b07
	Overhaul the status box * Subclass GtkBox instead of GtkContainer * Remove message editing * Use a GtkComboBox instead of our fake GtkComboBox * Move to item id's rather than indexes * Moved new status, and saved status to GActions * Removed the account and token_account properties. we now show primitives and saved status * Removed the ability to delete saved status from the widget * Use a widget template to construct the ui elements	f6bd096a84170fd799892ee918455c0769150c79

Diff:

Revision 4 (+1160 -4202)

Show changes

	ChangeLog.API
	libpurple/savedstatuses.c
	pidgin/gtkaccount.c
	pidgin/gtkblist.c
	pidgin/gtkconn.c
	pidgin/gtkstatusbox.h
	pidgin/gtkstatusbox.c
	pidgin/meson.build
	6 more

Ship it!

```
Ship It!
```

Review Board 6.0.2

Overhaul the status box

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Bugs:

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)