Convert TalkatuView to Gtk4

Review Request #1255 — Created Jan. 30, 2022 and submitted

Information

talkatu/talkatu
gtk4

Reviewers

Convert TalkatuView to Gtk4

Tested with gtk4-builder-tool preview view.ui and compiled with ninja talkatu/libtalkatu.so.0.1.0.p/talkatuview.c.o to verify there were no warnings/errors.

Summary ID
Convert TalkatuView to Gtk4
a60b5cc0243c19b8df8325987cae45d15554b051
Description From Last Updated

Need to add view.ui to POTFILES after 1256 is merged

grimgrim

Why gx/gy and not wx/wy like below?

QuLogicQuLogic

Am I confused, or should this check be the opposite?

QuLogicQuLogic

I believe this controller reacts to GDK_BUTTON_PRIMARY button by default, but the callback also checks for button 2.

QuLogicQuLogic
grim
  1. 
      
  2. Need to add view.ui to POTFILES after 1256 is merged

  3. 
      
grim
grim
grim
grim
QuLogic
  1. 
      
  2. talkatu/talkatuview.c (Diff revision 2)
     
     
     

    Why gx/gy and not wx/wy like below?

  3. talkatu/talkatuview.c (Diff revision 2)
     
     
     
     

    Am I confused, or should this check be the opposite?

  4. talkatu/talkatuview.c (Diff revision 2)
     
     

    I believe this controller reacts to GDK_BUTTON_PRIMARY button by default, but the callback also checks for button 2.

  5. 
      
grim
QuLogic
  1. Ship It!
  2. 
      
grim
Review request changed

Status: Closed (submitted)

Loading...