Summary

Stop saving status to accounts.xml

Review Request #1190 — Created Dec. 14, 2021 and submitted Dec. 17, 2021, 3:20 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17566

Depends On

Reviewers

Groups

pidgin

People

Description

I suspected this wasn't necessary for awhile, but finally tried it and I can't
seem to find anything that broke when I removed it.

Fixes PIDGIN-17566

Testing Done

Connected a Bonjour account, set the status to away with a message, stopped Pidgin, verified that status.xml contained what looked correct, then restarted Pidgin and verified that the status was set to the previous status before exiting.

Added an XMPP account, set the status to do not disturb with a message, closed pidgin, verified status.xml looked mostly correct, then restarted Pidgin and verified that the statuses were set to the previous statuses for both accounts.

Commits

Summary	ID
Stop saving status to accounts.xml I suspected this wasn't necessary for awhile, but finally tried it and I can't seem to find anything that broke when I removed it. Fixes PIDGIN-17566	d793dd45577293c5d4be2f5f5462c35a39a2dc10

I understand we don't need to save/load the existing builtin statuses, but what part saves/loads the (possibly per-account) status now?

grim Dec. 16, 2021, 8:40 a.m.

They're saved as a transient status in status.xml.

QuLogic Dec. 17, 2021, 3:17 a.m.
```
Ah, OK.
```

Ship it!

```
Ship It!
```

Review Board 6.0.2

Stop saving status to accounts.xml

Information

Reviewers

Status: Closed (submitted)