Clear conversation typing source ID in callback

 






 

 


  Review Request #1123
  —
  Created Nov. 3, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  sadiq
 









 
 

  pidgin/pidgin
 









 
 

  release-2.x.y
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  pidgin
 









 
 

  
 






 








 





  


 
 

  
Since the callback is run only once, the source ID should be
set to 0 so that the source ID won t be an invalid value.

This avoids a GLib critical on removing the invalid Source ID

 








  


 
 

  
Build and run pidgin and verified that the GLib warning has gone in logs

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Clear conversation typing source ID in callback
     
Since the callback is run only once, the source ID should be
set to 0 so that the source ID won t be an invalid value.

This avoids a GLib critical on removing the invalid Source ID

    

   
  		
  f0c5c1d26f47e459dbc5d9140261e313beac472c
  Mohammed Sadiq
 


 
  
 
 
  
   
    

     Clear conversation typing source ID in callback
     
Since the callback is run only once, the source ID should be
set to 0 so that the source ID won t be an invalid value.

This avoids a GLib critical on removing the invalid Source ID

    

   
  		
  49ce3f5e1b18ee7065fe622f8936a6c1185490a8
  Mohammed Sadiq
 




    


    
    

   

  

 









 

  

   
    

     
      
      libpurple/conversation.c
     
    

   
  

 










     

    

   

  

  

   
   Loading...