Summary

Add a gtk-config-frame-cb property to PidginPluginInfo as it used to be there and some plugins were still trying to set it.

Review Request #1090 — Created Oct. 21, 2021 and submitted Oct. 23, 2021, 7:19 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Add a gtk-config-frame-cb property to PidginPluginInfo as it used to be there and some plugins were still trying to set it.

Testing Done

ran in a devenv with G_DEBUG=fatal-warnings gdb --args pidgin3 and verified that the program didn't halt on the gestures plugin anymore.

Commits

Summary	ID
Add a gtk-config-frame-cb property to PidginPluginInfo as it used to be there and some plugins were still trying to set it.	49a2139d308e77f90a632f764f88cc2ce1dcb280

Issues

Description	From	Last Updated
Everything is indented with spaces instead of tabs.	QuLogic	Oct. 23, 2021, 6:35 a.m.
Are we eventually moving this to GPlugin itself?	QuLogic	Oct. 23, 2021, 6:35 a.m.
Extra blank line.	QuLogic	Oct. 23, 2021, 7:17 a.m.

Show all issues

Everything is indented with spaces instead of tabs.

grim Oct. 23, 2021, 6:12 a.m.

I am going to have to have some words with sublime text...

Show all issues

Are we eventually moving this to GPlugin itself?

grim Oct. 23, 2021, 6:12 a.m.

maybe? I've been back and forth on that a few times. Like we could have a GPluginGtkPluginInfo struct that has something like this, but to work properly in other languages users still need to subclass something. So something more like an interface in gplugin or just have PidginPluginInfo having the vfunc is probably the way to go.

Commits:

	Summary	ID
	Add a gtk-config-frame-cb property to PidginPluginInfo as it used to be there and some plugins were still trying to set it.	f071fd1264bc94907ca66205404c28e6fec41988
	Add a gtk-config-frame-cb property to PidginPluginInfo as it used to be there and some plugins were still trying to set it.	1c542d69e9e86a03e779d378eb2f61f835fcdf86

Diff:

Revision 2 (+144 -6)

Show changes

	pidgin/pidginplugininfo.h
	pidgin/pidginplugininfo.c

Ship it!

```
Ship It!
```
pidgin/pidginplugininfo.c (Diff revision 2)
Show all issues
```
Extra blank line.
```

Change Summary:

remove extra new line.

Commits:

	Summary	ID
	Add a gtk-config-frame-cb property to PidginPluginInfo as it used to be there and some plugins were still trying to set it.	1c542d69e9e86a03e779d378eb2f61f835fcdf86
	Add a gtk-config-frame-cb property to PidginPluginInfo as it used to be there and some plugins were still trying to set it.	49a2139d308e77f90a632f764f88cc2ce1dcb280

Diff:

Revision 3 (+142 -6)

Show changes

	pidgin/pidginplugininfo.h
	pidgin/pidginplugininfo.c

Review Board 6.0.2

Add a gtk-config-frame-cb property to PidginPluginInfo as it used to be there and some plugins were still trying to set it.

Information

Reviewers

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)

pidgin/pidginplugininfo.c (Diff revision 2)