Add a gtk-config-frame-cb property to PidginPluginInfo as it used to be there and some plugins were still trying to set it.

Review Request #1090 — Created Oct. 21, 2021 and submitted

grim
pidgin/pidgin
default
pidgin
Add a gtk-config-frame-cb property to PidginPluginInfo as it used to be there and some plugins were still trying to set it.

ran in a devenv with G_DEBUG=fatal-warnings gdb --args pidgin3 and verified that the program didn't halt on the gestures plugin anymore.

Summary
Add a gtk-config-frame-cb property to PidginPluginInfo as it used to be there and some plugins were still trying to set it.
Description From Last Updated

Everything is indented with spaces instead of tabs.

QuLogicQuLogic

Are we eventually moving this to GPlugin itself?

QuLogicQuLogic

Extra blank line.

QuLogicQuLogic
QuLogic
  1. 
      
  2. Everything is indented with spaces instead of tabs.

    1. I am going to have to have some words with sublime text...

  3. Are we eventually moving this to GPlugin itself?

    1. maybe? I've been back and forth on that a few times. Like we could have a GPluginGtkPluginInfo struct that has something like this, but to work properly in other languages users still need to subclass something. So something more like an interface in gplugin or just have PidginPluginInfo having the vfunc is probably the way to go.

  4. 
      
grim
QuLogic
  1. Ship It!
  2. pidgin/pidginplugininfo.c (Diff revision 2)
     
     

    Extra blank line.

  3. 
      
grim
grim
Review request changed

Status: Closed (submitted)

Loading...