Summary

Fix the unit tests that were broke by the g_log transition

Review Request #1082 — Created Oct. 20, 2021 and submitted Oct. 20, 2021, 7:36 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

* xmlnode we verify that the error message went to stderr
* everything else we add the entire prefs tree for the preference we're trying to load

Testing Done

Ran the unit tests and verified that they passed again.

Commits

Summary	ID
Fix the unit tests that were broke by the g_log transition * xmlnode we verify that the error message went to stderr * everything else we add the entire prefs tree for the preference we're trying to load	cb669ad0ec2c6cd6525a9810c1c2081842e2a03e

Issues

Description	From	Last Updated
This comment can go too.	QuLogic	Oct. 20, 2021, 7:35 a.m.

Change Summary:

add /purple to for completeness even though it seems to work without it.

Commits:

	Summary	ID
	Fix the unit tests that were broke by the g_log transition * xmlnode we verify that the error message went to stderr * everything else we add the entire prefs tree for the preference we're trying to load	92fc0f0409d01526d1f9279f9e7bd51beb98a02d
	Fix the unit tests that were broke by the g_log transition * xmlnode we verify that the error message went to stderr * everything else we add the entire prefs tree for the preference we're trying to load	94d027da1b2154cb60c5fd68e6857eb0168a2cd7

Diff:

Revision 2 (+26 -10)

Show changes

	libpurple/tests/test_ui.c
	libpurple/tests/test_xmlnode.c

Ship it!

```
Ship It!
```
libpurple/tests/test_xmlnode.c (Diff revision 2)
Show all issues
```
This comment can go too.
```

Change Summary:

remove unnecessary comment.

Commits:

	Summary	ID
	Fix the unit tests that were broke by the g_log transition * xmlnode we verify that the error message went to stderr * everything else we add the entire prefs tree for the preference we're trying to load	94d027da1b2154cb60c5fd68e6857eb0168a2cd7
	Fix the unit tests that were broke by the g_log transition * xmlnode we verify that the error message went to stderr * everything else we add the entire prefs tree for the preference we're trying to load	cb669ad0ec2c6cd6525a9810c1c2081842e2a03e

Diff:

Revision 3 (+22 -10)

Show changes

	libpurple/tests/test_ui.c
	libpurple/tests/test_xmlnode.c

Review Board 6.0.2

Fix the unit tests that were broke by the g_log transition

Information

Reviewers

Change Summary:

Commits:

Diff:

Change Summary:

Commits:

Diff:

Status: Closed (submitted)