Summary

Fix console logging and turn it on unconditionally if we're doing a debug build

Review Request #1004 — Created Oct. 8, 2021 and submitted Oct. 8, 2021, 3:28 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Fix console logging and turn it on unconditionally if we're doing a debug build

Testing Done

Ran ninja reconfigure with a debug buildtype (which is the default build type) with console-logging on and off and verified it was turned on. Also ran ninja reconfigure with a release buildtype and verified that the console-logging option was honored.

Commits

Summary	ID
Fix console logging and Turn it on unconditionally if we're doing a debug build	b4cc317dc62ee76dc74094e4c194ad22a5638623

Summary:

-	Turn on console logging unconditionally if we're doing a debug build
+	Fix console logging and Turn it on unconditionally if we're doing a debug build

Description:

~		Turn on console logging unconditionally if we're doing a debug build
	~	Fix console logging and Turn it on unconditionally if we're doing a debug build

Commits:

	Summary	ID
	Turn on console logging automatically if we're doing a debug build	7e3dc8a9190a628d15e479df0cac98bf925967cd
	Fix console logging and Turn it on unconditionally if we're doing a debug build	b4cc317dc62ee76dc74094e4c194ad22a5638623

Diff:

Revision 2 (+16 -12)

Show changes

	meson.build
	libpurple/debug.c

Summary:

-	Fix console logging and Turn it on unconditionally if we're doing a debug build
+	Fix console logging and turn it on unconditionally if we're doing a debug build

Description:

~		Fix console logging and Turn it on unconditionally if we're doing a debug build
	~	Fix console logging and turn it on unconditionally if we're doing a debug build

Testing Done:

~		ran `ninja reconfigure` with a debug buildtype (which is the default build type) with console-logging on and off and verfied it was turned on. Also ran `ninja reconfigure` with a release buildtype and verified that the `console-logging` option was honored.
	~	Ran `ninja reconfigure` with a debug buildtype (which is the default build type) with console-logging on and off and verified it was turned on. Also ran `ninja reconfigure` with a release buildtype and verified that the `console-logging` option was honored.

Ship it!

```
Ship It!
```

Review Board 6.0.2

Fix console logging and turn it on unconditionally if we're doing a debug build

Information

Reviewers

Summary:

Description:

Commits:

Diff:

Summary:

Description:

Testing Done:

Status: Closed (submitted)